[Webkit-unassigned] [Bug 116818] Tighten FontGlyphs interfaces to take FontDescription instead of Font

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116818


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202963|review?                     |review+
               Flag|                            |




--- Comment #3 from Andreas Kling <akling at apple.com>  2013-05-27 03:55:50 PST ---
(From update of attachment 202963)
View in context: https://bugs.webkit.org/attachment.cgi?id=202963&action=review

> Source/WebCore/ChangeLog:8
> +        This gives better understanding of what the actual inputs are.

I like this change a lot.

> Source/WebCore/platform/graphics/FontFallbackList.h:107
> -    mutable unsigned m_pitch : 3; // Pitch
> +    mutable unsigned m_pitch : 3;

I think the "Pitch" here is to signify that the type of m_pitch is actually Pitch (the enum.)
Still pretty redundant, though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.