[Webkit-unassigned] [Bug 112615] [css3-text] Implement support for vertical writing mode in -webkit-text-underline-position

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112615





--- Comment #5 from Lamarque V. Souza <Lamarque.Souza at basyskom.com>  2013-05-24 08:12:13 PST ---
I did not have time to review all the patch, so I will write only the things I spotted in the first glance:

View in context: https://bugs.webkit.org/attachment.cgi?id=202797&action=review

> Source/WebCore/ChangeLog:12
> +        because these line should ignore veritcal-align like under underline in horizontal writing mode.

typo: "veritcal-align"

> Source/WebCore/rendering/InlineTextBox.cpp:1011
> +    default:

Do not move this code into the default statement. Read comment https://bugs.webkit.org/show_bug.cgi?id=102795#c63 about this.

> LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-right-left-horizontal.html:26
> +<span class="decoration" style="color: cyan; -webkit-text-underline-position: left right;">left right :p The line should be alphabetic.</span>

This is an invalid value. It is ok that your patch defaults to alphabetic here. However, your patch should update LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position.html to check for this and other invalid values. Anything that is not either "auto", "alphabetic", "under", "under left" or "under right" is invalid.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.