[Webkit-unassigned] [Bug 116670] Fix loader/go-back-cached-main-resource.html test

Thu May 23 10:31:00 PDT 2013

https://bugs.webkit.org/show_bug.cgi?id=116670

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202708|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |

--- Comment #2 from Alexey Proskuryakov <ap at webkit.org>  2013-05-23 10:29:29 PST ---
(From update of attachment 202708)
View in context: https://bugs.webkit.org/attachment.cgi?id=202708&action=review

Getting rid of the timeout is a very welcome improvement, so r=me. Please consider the suggestion below.

> LayoutTests/loader/resources/first-page.html:21
> +<body onpageshow="registerListeners();">

This is quite misleading. We only need to register listeners on first load, they are already present when restoring from cache. But the function does more than its name says, which is why it's necessary to call it every time!

One way to clean this up would be to rename the function to "didShowPage", and use event.persisted property to check if we are handling the initial load. Or just use an anonymous function, and register it as window.onpageshow = function (event) { ... }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.