[Webkit-unassigned] [Bug 116658] Path: upstream the missing bits from the BlackBerry port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116658





--- Comment #3 from Alberto Garcia <agarcia at igalia.com>  2013-05-23 10:05:47 PST ---
(In reply to comment #2)
> > Source/WebCore/platform/graphics/Path.cpp:154
> >      platformAddPathForRoundedRect(rect, topLeftRadius, topRightRadius, bottomLeftRadius, bottomRightRadius);
>
> Too bad this is needed, but since CG is doing exactly the same I guess it is acceptable.
>
> FWIW this method does not make a lot of sense for the non-CG/non-blackberry ports. They are always going to call 'addBeziersForRoundedRect'. Not sure if it's worth cleaning up in a follow-up though.

I guess I can try to clean it up in a separate patch.

> > Source/WebCore/platform/graphics/Path.h:58
> > +typedef BlackBerry::Platform::Graphics::Path PlatformPath;
>
> This makes sense. Too bad there seems to be no way to define nested
> > namespaces in one go, it's kinda ugly .though.

One alternative would be something like

namespace BlackBerry { namespace Platform { namespace Graphics {

which looks a bit better IMO but I'm not sure if that's accepted
style? JSC seems to use something like that...

> > Source/WebCore/platform/graphics/Path.h:174
> > +        Path(const PlatformPath&);
>
> This is not used in the patch right? Where is it used exactly?

In DefaultTapHighlight::paintContents() at least.

    Path path(m_region.boundaryPath());

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.