[Webkit-unassigned] [Bug 76048] [GTK] fast/text/font-kerning.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76048


Denis Nomiyama (dnomi) <d.nomiyama at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202669|review?                     |
               Flag|                            |




--- Comment #9 from Denis Nomiyama (dnomi) <d.nomiyama at samsung.com>  2013-05-23 10:01:05 PST ---
(From update of attachment 202669)
View in context: https://bugs.webkit.org/attachment.cgi?id=202669&action=review

>> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp:502
>> +        } else
> 
> Hrm. A more likely location for this change is HarfBuzzShaper::setFontFeatures where the rest of the feature are set, no? Aren't you also adding 'kern' to the feature list here instead of removing it?

Good point about setFontFeatures(). The idea is to add 'kern' as 0 (disabled) to the feature list in case of NoneKerning. I will also include a case for NormalKerning.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.