[Webkit-unassigned] [Bug 114862] [EFL][WK2]<select> element's text is clipped when a height is specified along with CSS line-height.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 23 08:28:50 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=114862


Ryuan Choi <ryuan.choi at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202704|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #16 from Ryuan Choi <ryuan.choi at samsung.com>  2013-05-23 08:27:18 PST ---
(From update of attachment 202704)
View in context: https://bugs.webkit.org/attachment.cgi?id=202704&action=review

I think that we should check efl layout test not to have more regression.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:872
> +        style->setFontSize(RENDER_THEME_EFL_CONTROL_FONT_SIZE);

I think that we should more test about this.

When increased font size, Our results are fixed to 13 but others (chrome and ff on linux) looks different.

And your changelog looks missing about this, do you really want to change this for bug?

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:874
> +        style->setHeight(Length(Auto));

Indentation is one of important coding style rules.

please fix them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list