[Webkit-unassigned] [Bug 116658] Path: upstream the missing bits from the BlackBerry port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116658





--- Comment #2 from Xan Lopez <xan.lopez at gmail.com>  2013-05-23 06:24:45 PST ---
(From update of attachment 202660)
View in context: https://bugs.webkit.org/attachment.cgi?id=202660&action=review

> Source/WebCore/platform/graphics/Path.cpp:154
>      platformAddPathForRoundedRect(rect, topLeftRadius, topRightRadius, bottomLeftRadius, bottomRightRadius);

Too bad this is needed, but since CG is doing exactly the same I guess it is acceptable.

FWIW this method does not make a lot of sense for the non-CG/non-blackberry ports. They are always going to call 'addBeziersForRoundedRect'. Not sure if it's worth cleaning up in a follow-up though.

> Source/WebCore/platform/graphics/Path.h:58
> +typedef BlackBerry::Platform::Graphics::Path PlatformPath;

This makes sense. Too bad there seems to be no way to define nested namespaces in one go, it's kinda ugly .though.

> Source/WebCore/platform/graphics/Path.h:174
> +        Path(const PlatformPath&);

This is not used in the patch right? Where is it used exactly?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.