[Webkit-unassigned] [Bug 116312] [WK2][WTR]Adding Layout test framework for MHTML page content

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116312





--- Comment #10 from Santosh Mahto <santoshbit2007 at gmail.com>  2013-05-23 03:19:30 PST ---
(In reply to comment #9)
> (From update of attachment 202253 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=202253&action=review
> 
> This is a start, but that is not the proper way to test code with an API on the UIProcess.

 I thought this is last :):)

> Instead, what should happen is the InjectedBundle sends a message to the UIProcess asking for the data. The UIProcess uses the public API (WKPageGetContentsAsMHTMLData) and return the value to the injected bundle asynchronously.

 you seems right.
> On a more generic standpoint. Why wouldn't the test always dump 2 expected results? One binary, one text?

 we don't need to dump two when layout test will just compare with one base line expected text file.
and we are doing content test, to do encoding test(binary) we dont need to duplicate everything and adding differnt archive format

binary specifies only that content(main resource  & subresources) to be encoded in binary or not , MHTML archive format(headers) will still be in same format . MHTMLBinaryArchive is  not any archive format.
So there is one Archive format MHTML where  data content(e.g image) are encoded with ascii(default) or Binary(if sspecified m_useBinaryEncoding = true)

its like in webarchive  <data>  </data> encoding is decided by binary but archive format is always XML 

> > Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:325
> > +    bool m_useBinaryEncoding;

         This doesnot interfere with MHTML archive format, just changes the encoding on inside content resources

> Instead of this, I would just have two WhatToDump:
>     MHTMLArchive && MHTMLBinaryArchive

 MHTMLArchive && MHTMLBinaryArchive  are not different archive as I said above.
specifiying two archive format name looks confusing to me and it will lead to code duplicate(redo everything again for MHTMLBinaryArchive.

For MHTML layout tests means we are testing for content of MHTML dump.So its not must seems to mix up encoding test 

So I think one javascript api  dumpAsMHTML(bool m_useBinaryEnCoding = false) is good enough

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.