[Webkit-unassigned] [Bug 116654] [BlackBerry] DRT - crashed on GraphicsContext3D::makeContextCurrent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116654





--- Comment #6 from Arvid Nilsson <anilsson at rim.com>  2013-05-23 02:16:34 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 202648 [details] [details])
> > Sorry for the misleading internal review - you should make the WebGLLayerWebKitThread::m_webGLContext a weak pointer rather than a ref pointer... Or fix it some other way...
> 
...

> WebGLLayerWebKitThread::webGLContextDestroyed()
> {
>     if (m_webGLContext && m_webGLContext->makeContextCurrent())
>         deleteFrontBuffer();
> }

Actually, there's already a method that does exactly this, deleteTextures(). It should be like this:

WebGLLayerWebKitThread::webGLContextDestroyed()
{
    deleteTextures();
    m_webGLContext = 0;
}

You can also replace the call in the destructor to call deleteTextures():

 WebGLLayerWebKitThread::~WebGLLayerWebKitThread()
 {
-    if (m_webGLContext && m_webGLContext->makeContextCurrent())
-        deleteFrontBuffer();
+    deleteTextures();
 }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.