[Webkit-unassigned] [Bug 116312] [WK2][WTR]Adding Layout test framework for MHTML page content

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116312


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202253|review?                     |review-
               Flag|                            |




--- Comment #9 from Benjamin Poulain <benjamin at webkit.org>  2013-05-22 17:00:59 PST ---
(From update of attachment 202253)
View in context: https://bugs.webkit.org/attachment.cgi?id=202253&action=review

This is a start, but that is not the proper way to test code with an API on the UIProcess.

Instead, what should happen is the InjectedBundle sends a message to the UIProcess asking for the data. The UIProcess uses the public API (WKPageGetContentsAsMHTMLData) and return the value to the injected bundle asynchronously.

On a more generic standpoint. Why wouldn't the test always dump 2 expected results? One binary, one text?

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:325
> +    bool m_useBinaryEncoding;

Instead of this, I would just have two WhatToDump:
    MHTMLArchive && MHTMLBinaryArchive

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.