[Webkit-unassigned] [Bug 95923] [EFL] Implement GCActivityCallback

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95923





--- Comment #39 from Hojong Han <hojong.han at samsung.com>  2013-05-22 01:33:37 PST ---
(From update of attachment 202505)
View in context: https://bugs.webkit.org/attachment.cgi?id=202505&action=review

>> Source/JavaScriptCore/heap/HeapTimer.cpp:175
>> +{
> 
> Please see my earlier comment about adding a thread check here.

HeapTimer can be created in other than main thread, but it does not make m_timer run because other threads might not have an ecore loop.
In this vein, ecore_init() in constructor and ecore_shutdown() in destructor are necessary.

>> Source/JavaScriptCore/jsc.cpp:805
>> +    ShellEnvironment env;
> 
> Why add this to jscmain instead of main() like other ports?

I'll remove this if my comment upper is acceptable

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.