[Webkit-unassigned] [Bug 116467] [Qt][WK2] Fix Mountain Lion builds after r150277.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116467





--- Comment #7 from Michael Brüning <michael.bruning at digia.com>  2013-05-21 08:43:13 PST ---
(In reply to comment #6)
> (In reply to comment #3)
> > I believe that this can go in without owner approval, correct me if I'm wrong.
> 
> I think that’s wrong. This WKBase.h file is shipped as a public header on Mac. I don’t think it’s appropriate to have a BUILDING_QT__ #if in it. We probably need a different solution.
> 
> Anders? Sam?

Ah, sorry, I was not aware of that. I just assumed the BUILDING_ would be okay since there were both BUILDING_EFL__ and BUILDING_GTK__ #if guards around the efl and GTK specific WKBase header includes in it already. Should we use to PLATFORM(xyz) #ifs or which would be the preferred guard?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.