[Webkit-unassigned] [Bug 115028] [EFL] Add command line option to MiniBrowser to set cookies policy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115028





--- Comment #13 from Andrzej Badowski <a.badowski at samsung.com>  2013-05-21 07:19:39 PST ---
(In reply to comment #9)
> (From update of attachment 202276 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=202276&action=review
> 
> I think adding such command line parameter is a good idea but I don't like the approach.
> 
> > Tools/MiniBrowser/efl/main.c:161
> > +            ('p', "policy-cookies", "cookies policy: 0 - always accept, 1 - never accept, 2 - don't accept third-party cookies", 2),
> 
> Using integers is really obscure IMHO. Why don't we use user-readable strings instead? It's not like performance really matters here. This is a user-facing setting and it should be user-readable.

(In reply to comment #10)
> (In reply to comment #3)
> 
> > >> Tools/MiniBrowser/efl/main.c:1669
> > >> +    cookies_policy = cookies_policy % 3;
> > > 
> > > I think we should remain that user can set the policy.
> > 
> > There's an extra protection to set for the policy only an allowed value.
> 
> I'm still not sure if we need to support even when user uses a value out of the policy range. Is there any reason to support it ? IMHO, it is correct way to print a message - the input value is out of range.

(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #3)
> > 
> > > >> Tools/MiniBrowser/efl/main.c:1669
> > > >> +    cookies_policy = cookies_policy % 3;
> > > > 
> > > > I think we should remain that user can set the policy.
> > > 
> > > There's an extra protection to set for the policy only an allowed value.
> > 
> > I'm still not sure if we need to support even when user uses a value out of the policy range. Is there any reason to support it ? IMHO, it is correct way to print a message - the input value is out of range.
> 
> Or simply use a string as I propose.

(In reply to comment #12)
> (In reply to comment #11)
> > (In reply to comment #10)
> > > (In reply to comment #3)
> > > 
> > > > >> Tools/MiniBrowser/efl/main.c:1669
> > > > >> +    cookies_policy = cookies_policy % 3;
> > > > > 
> > > > > I think we should remain that user can set the policy.
> > > > 
> > > > There's an extra protection to set for the policy only an allowed value.
> > > 
> > > I'm still not sure if we need to support even when user uses a value out of the policy range. Is there any reason to support it ? IMHO, it is correct way to print a message - the input value is out of range.
> > 
> > Or simply use a string as I propose.
> 
> Yes, good idea as well. ;)

There's good idea to use strings in command-line. At the beginning I thought it would be more complicated having a relatively long texts reflecting the sense of individual cases than put simply one char (0,1,2) , but now I think text options could be short (i.e. never, always, third-party) and will be certainly more intuitive then integers. User always can read detailed explanation by --help option. I will prepare new appropriate patch also taking into account information for user about wrong option.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.