[Webkit-unassigned] [Bug 116448] [BlackBerry] Make PagePopup implementation independent from WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116448





--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-05-21 03:02:29 PST ---
(In reply to comment #3)
> (From update of attachment 202295 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=202295&action=review
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:468
> > +    // Destroy popup if we have.
> 
> If we have one? I think this is self-explanatory, and doesn't need any comment.
> 
> > Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:-153
> > -    // Destroy popup if we have.
> 
> Now I see where you got that comment from =)

:-) I'll remove it anyway.

> > Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.h:36
> > +class PagePopupBlackBerryClient {
> 
> The "BlackBerry" in the name seems redundant, since we're in the BlackBerry::WebKit namespace. However, perhaps you can rename the classes to just PagePopup/PagePopupClient once the cross platform ones have been removed.

Exactly, that was my idea. At the moment we would need to use a different #ifndef #define block for the PagePopupClient header if we use the same name. I think it will be easier to rename it when we move the files to WebKitSupport, making this patch as simple as possible.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.