[Webkit-unassigned] [Bug 116448] [BlackBerry] Make PagePopup implementation independent from WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116448





--- Comment #3 from Arvid Nilsson <anilsson at rim.com>  2013-05-21 02:40:22 PST ---
(From update of attachment 202295)
View in context: https://bugs.webkit.org/attachment.cgi?id=202295&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:468
> +    // Destroy popup if we have.

If we have one? I think this is self-explanatory, and doesn't need any comment.

> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:-153
> -    // Destroy popup if we have.

Now I see where you got that comment from =)

> Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.h:36
> +class PagePopupBlackBerryClient {

The "BlackBerry" in the name seems redundant, since we're in the BlackBerry::WebKit namespace. However, perhaps you can rename the classes to just PagePopup/PagePopupClient once the cross platform ones have been removed.

> Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.h:44
> +    //  - window.setValueAndClosePopup(number, string).

Does it really support this, if we dont define ENABLE(PAGE_POPUP)? Don't you need to inject some native function into JavaScript that does this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.