[Webkit-unassigned] [Bug 116463] Clients should have a way to extend rendering suppression

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116463


Andy Estes <aestes at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202327|review?                     |review+
               Flag|                            |




--- Comment #4 from Andy Estes <aestes at apple.com>  2013-05-20 16:22:11 PST ---
(From update of attachment 202327)
View in context: https://bugs.webkit.org/attachment.cgi?id=202327&action=review

> Source/WebCore/page/FrameView.h:426
> +    bool visualUpdatesAllowedByClient() { return m_visualUpdatesAllowedByClient; }

This can be const-qualified.

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:87
> +WK_EXPORT WKRenderingSuppressionToken WKBundlePageExtendIncrementalRenderingSuppression(WKBundlePageRef page) WARN_UNUSED_RETURN;
> +WK_EXPORT void WKBundlePageStopExtendingIncrementalRenderingSuppression(WKBundlePageRef page, WKRenderingSuppressionToken token);

You don't need to name these arguments since their types are self-descriptive.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4189
> +    unsigned token = ++m_maximumRenderingSuppressionToken;

Could be m_maximumRenderingSuppressionToken++ so that 0 is allowed to be a token.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.