[Webkit-unassigned] [Bug 116463] Clients should have a way to extend rendering suppression

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116463





--- Comment #2 from Andy Estes <aestes at apple.com>  2013-05-20 15:03:36 PST ---
(From update of attachment 202319)
View in context: https://bugs.webkit.org/attachment.cgi?id=202319&action=review

> Source/WebCore/dom/Document.cpp:1329
> +#ifndef NDEBUG
> +    if (!view()->visualUpdatesAllowedByClient())
> +        WTFLogAlways("Visual updates are disallowed by client, but watchdog is forcing visual updates to be allowed.\n");
> +#endif

I think it's weird that we still fire this timer even if the client is explicitly suppressing visual updates. As you mentioned on IRC, if they want some sort of slow-loading timer then they can implement it themselves.

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:86
> +WK_EXPORT unsigned WKBundlePageAcquireRenderingSuppressionToken(WKBundlePageRef page) WARN_UNUSED_RETURN;
> +WK_EXPORT void WKBundlePageRelinquishRenderingSuppressionToken(WKBundlePageRef page, unsigned token);

We talked about these names on IRC. Here was my suggestion:

typedef unsigned WKRenderingSuppressionToken;
WK_EXPORT WKRenderingSuppressionToken WKBundlePageExtendIncrementalRenderingSuppression(WKBundlePageRef) WARN_UNUSED_RETURN;

And then you suggested this for the corresponding stop function:

WK_EXPORT void WKBundlePageStopExtendingIncrementalRenderingSuppression(WKBundlePageRef, WKRenderingSuppressionToken);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.