[Webkit-unassigned] [Bug 116125] pathSuitableForTestResult returns duplicate path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116125


Tim Horton <timothy_horton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202301|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #9 from Tim Horton <timothy_horton at apple.com>  2013-05-20 12:20:34 PST ---
(From update of attachment 202301)
View in context: https://bugs.webkit.org/attachment.cgi?id=202301&action=review

> Tools/ChangeLog:22
> +        Pass the main frame's URL to pathSuitableForTestResult.
> +        (WTR::dumpResponseDescriptionSuitableForTestResult):
> +        Pass the main frame's URL to pathSuitableForTestResult.
> +        (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
> +        Pass the main frame's URL to pathSuitableForTestResult.
> +        (WTR::InjectedBundlePage::didInitiateLoadForResource):
> +        Pass the main frame's URL to pathSuitableForTestResult.
> +        (WTR::InjectedBundlePage::willSendRequestForFrame):
> +        Pass the main frame's URL to pathSuitableForTestResult.
> +        (WTR::InjectedBundlePage::didReceiveResponseForResource):
> +        Pass the main frame's URL to pathSuitableForTestResult.

You could have this once at the bottom of the set of things-that-have-the-same-comment.

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:605
> +    static_cast<InjectedBundlePage*>(const_cast<void*>(clientInfo))->willPerformClientRedirectForFrame(frame, url, delay, date, WKBundleFrameCopyURL(WKBundlePageGetMainFrame(page)));

Who owns the string copy you're making here? Who will free it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.