[Webkit-unassigned] [Bug 116108] Improve -webkit-text-underline-position memory usage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116108





--- Comment #11 from Lamarque V. Souza <Lamarque.Souza at basyskom.com>  2013-05-17 06:45:29 PST ---
(In reply to comment #10)
> (From update of attachment 201998 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=201998&action=review
> 
> We should add compile-time size assertions for RootInlineBox and friends so this doesn’t happen again.

I will submit a patch for that.

> > Source/WebCore/ChangeLog:12
> > +        number of interactions to calcule it is less than 10, so it is a small
> 
> ‘interactions’ is an odd word to use here. Calls? Also, calculate.

It should have been "iterations", I wrote that word because of the "for" loop in computeMaxLogicalTop, but "calls" looks better. What I want to explain is that computeMaxLogicalTop needs to iterate through all descendants of the RootInlineBox. The number of descendants is usually very small (less than 10) by what I have checked.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.