[Webkit-unassigned] [Bug 112913] [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112913





--- Comment #13 from Mario Sanchez Prada <mario at webkit.org>  2013-05-17 02:58:05 PST ---
(In reply to comment #11)
> [...]
> Probably it would be feasible. It requires some additional casting code in 
> AccessibilityController.cpp (rootElement and focusedElement methods)

Yes, I was not expecting it to be a one liner change, that's why I asked. In any case, it's just a suggestion, but if it's too cumbersome and/or nobody else sees a benefit on this, I'd be fine with the current solution.

> I'm wondering, PlatformUIElement is used also as a constructor and function's 
> parameter and a return value as well. Would it be too much refs and derefs of 
> temporary objects ?. What to you think about it ?.

Hrm... I see. Maybe it's going to be too much then, you could just use PassRefPtr if they were not GObjects, but you have GRefPtr here, and that would mean I'm afraid too many changes for what it should be something quite simple in the end.

So, I think I'm leaning more towards keeping it as you have it right now unless, as I said before, anyone else opposes to it.

Thanks for considering my suggestions

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.