[Webkit-unassigned] [Bug 114781] [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114781





--- Comment #5 from Seokju Kwon <seokju.kwon at gmail.com>  2013-05-16 15:54:40 PST ---
(In reply to comment #3)
> (From update of attachment 198671 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=198671&action=review
> 
> > Source/WebKit/efl/ChangeLog:9
> > +
> 
> Please check the following entry in efl-wk1 TestExpectations:
> # EFL's DRT needs CONFIRM NAVIGATION messages
> webkit.org/b/87246 fast/loader/form-submission-after-beforeunload-cancel.html [ Failure ]
> 
> If the test now passes please unskip it in this patch.
> 
> > Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:97
> > +    return EINA_TRUE;
> 
> You need to return !gTestRunner->shouldStayOnPageAfterHandlingBeforeUnload() instead of unconditionally EINA_TRUE I believe. Please check other ports.

Chris : Thanks for your review and comments. I will check them out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.