[Webkit-unassigned] [Bug 116108] Improve -webkit-text-underline-position memory usage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116108


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #201972|review?                     |review-
               Flag|                            |




--- Comment #7 from Benjamin Poulain <benjamin at webkit.org>  2013-05-16 15:27:37 PST ---
(From update of attachment 201972)
View in context: https://bugs.webkit.org/attachment.cgi?id=201972&action=review

The patch looks like a good idea but I have concerns about constness.

Either those functions are badly named, or they should be const.

> Source/WebCore/rendering/RootInlineBox.cpp:345
> +float RootInlineBox::maxLogicalTop()
> +{
> +    float maxLogicalTop = 0;
> +    computeMaxLogicalTop(maxLogicalTop);
> +    return maxLogicalTop;
> +}
> +#endif // CSS3_TEXT

Looks like computeMaxLogicalTop() should be const. Then maxLogicalTop() should be const too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.