[Webkit-unassigned] [Bug 116049] Add a DisplayNotificationObserver class to handle Display notifications

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116049





--- Comment #45 from Ryosuke Niwa <rniwa at webkit.org>  2013-05-16 13:48:36 PST ---
(In reply to comment #44)
> (In reply to comment #39)
> > (From update of attachment 201907 [details] [details])
> > I don't see why this needs to be exposed as a DisplayNotificationObserver singleton class, couldn't the API just be "isScreenDimmed()"?
> 
> That was my very first patch, but I was told that that was not the way general WebKit way of doing things like this.

I would much prefer the single function interface andersca suggested. We can use singleton internally but that's an implementation detail.  If you didn't want to pollute WebCore namespace, we can wrap it inside a namespace even.

> As a side note, it does make things more extensible (although I was told that the "more extensible" argument is usually not a good one as well).

We should make things more extensible when it needs to be. It's not like this is a public interface we want to expose somewhere.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.