[Webkit-unassigned] [Bug 116049] Add a DisplayNotificationObserver class to handle Display notifications

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 16 13:42:07 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=116049





--- Comment #44 from Roger Fong <roger_fong at apple.com>  2013-05-16 13:40:33 PST ---
(In reply to comment #39)
> (From update of attachment 201907 [details])
> I don't see why this needs to be exposed as a DisplayNotificationObserver singleton class, couldn't the API just be "isScreenDimmed()"?

That was my very first patch, but I was told that that was not the way general WebKit way of doing things like this.
As a side note, it does make things more extensible (although I was told that the "more extensible" argument is usually not a good one as well). To me this sounds like a "to each their own" decision.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list