[Webkit-unassigned] [Bug 115152] [EFL][WK2] Add APIs to set/get the text zoom factor.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115152





--- Comment #2 from Christophe Dumez <dchris at gmail.com>  2013-05-16 12:25:15 PST ---
(From update of attachment 199627)
View in context: https://bugs.webkit.org/attachment.cgi?id=199627&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:860
> + * @param new text zoom factor

Missing @param name

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:864
> +EAPI Eina_Bool ewk_view_text_zoom_factor_set(Evas_Object* ewkView, double zoomFactor);

Star on wrong side. First parameter should be called "o"

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:873
> +EAPI double ewk_view_text_zoom_factor_get(const Evas_Object* ewkView);

Ditto.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1006
> +}

Would be nice to try a few error cases as well. What if I call ewk_view_text_zoom_factor_set(webView(), -1) ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.