[Webkit-unassigned] [Bug 114960] Wrong text position when you click backspace on the line below the image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114960


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #201183|review?                     |review-
               Flag|                            |




--- Comment #29 from Ryosuke Niwa <rniwa at webkit.org>  2013-05-16 08:49:48 PST ---
(From update of attachment 201183)
View in context: https://bugs.webkit.org/attachment.cgi?id=201183&action=review

We don't add a test by itself. This patch needs to be merged with the actual fix.

> LayoutTests/editing/deleting/merge-image-and-text.html:13
> +Markup.description('Testcase for bug https://webkit.org/b/114960: Wrong text position when you click backspace on the line below the image.\n'+
> +'The test passes if "text1" appears on the right side of the image.');

Since everyone can look at trac or svn blame to figure out for which bug this test was added, it's not that interesting to repeat the bug URL and title.
Instead you should describe what this test is doing; the specific condition under which deletion occurs.

> LayoutTests/editing/deleting/merge-image-and-text.html:16
> +var testedHTML = document.getElementById('editableContent');

We should name this variable like container or editableContent to be more descriptive.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.