[Webkit-unassigned] [Bug 112913] [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112913





--- Comment #10 from Mario Sanchez Prada <mario at webkit.org>  2013-05-16 05:44:57 PST ---
(From update of attachment 201937)
View in context: https://bugs.webkit.org/attachment.cgi?id=201937&action=review

> Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:252
> +#if PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))
> +    GRefPtr<AtkObject> m_element;
> +#else
>      PlatformUIElement m_element;
> +#endif

Would it be possible to update the typedef AtkObject* PlatformUIElement in this file to be typedef GRefPtr<AtkObject> PlatformUIElement, instead of changing this here?

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:283
> +    return m_element.get() == otherElement->platformUIElement();

I think you don't need the .get() here

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:288
> +    if (!m_element.get() || !ATK_IS_OBJECT(m_element.get()))

I don't think you need to use get() for checking !m_element.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.