[Webkit-unassigned] [Bug 116099] [Qt] UrlLoader::loadNext is broken in MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116099


Jocelyn Turcotte <jocelyn.turcotte at digia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #201701|review?                     |review-
               Flag|                            |




--- Comment #3 from Jocelyn Turcotte <jocelyn.turcotte at digia.com>  2013-05-16 05:34:39 PST ---
(From update of attachment 201701)
View in context: https://bugs.webkit.org/attachment.cgi?id=201701&action=review

> Tools/MiniBrowser/qt/UrlLoader.cpp:49
> +    connect(this, SIGNAL(loadSucceeded()), this, SLOT(frameLoadFinished()));
> +    connect(this, SIGNAL(loadFailed()), this, SLOT(frameLoadFinished()));

loadSucceeded and loadFailed have the same effect, and UrlLoader is unlikely going to have external components using its API.
So no need to have two different signals, just use a loadFinished() signal that is triggered by LoadSucceededStatus, LoadFailedStatus and LoadStoppedStatus.

> Tools/MiniBrowser/qt/UrlLoader.cpp:141
> +

We don't usually put an empty line between the cases.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.