[Webkit-unassigned] [Bug 115884] Frame flattening prevents <HTML> in <OBJECT> from having scrollbars

Wed May 15 20:16:30 PDT 2013

https://bugs.webkit.org/show_bug.cgi?id=115884

--- Comment #21 from Jaehun Lim <ljaehun.lim at samsung.com>  2013-05-15 20:14:57 PST ---
(From update of attachment 201807)
View in context: https://bugs.webkit.org/attachment.cgi?id=201807&action=review

>> Source/WebCore/page/FrameView.cpp:519
>> +static bool requiresFrameFlattening(Frame* frame)
> 
> I think supportsFrameFlattenning is more appropriated.

Fixed.

>> Source/WebCore/page/FrameView.cpp:522
>> +    HTMLFrameOwnerElement* owner = frame->ownerElement();
> 
> You dont check if the frame is NULL here, while you do it in frameFlatteningEnabled(). Any particular reason? (should be symmetric unless there's a good reason for not to.)

Added null checking codes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.