[Webkit-unassigned] [Bug 115863] [WebSocket] Update pywebsocket to r760

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115863


Takeshi Yoshino <tyoshino at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tyoshino at google.com




--- Comment #7 from Takeshi Yoshino <tyoshino at google.com>  2013-05-14 21:56:20 PST ---
(In reply to comment #5)
> (In reply to comment #3)
> > Wait, why is this not supported? This has nothing to do with compression, please explain.
> 
> Blink's developers deleted them because they failed after pywebsocket update. I have just researched and the tests were restored in a later commit [1]. I need to figure out what changes are necessary to make them work properly (they still does not work here).

Yes. They were originally testing the Sec-WebSocket-Location header of HyBi 00 that no longer exists in RFC 6455. As side effect, they were testing that the string passed to the WebSocket constructor as url argument are correctly parsed (in order to build the Sec-WebSocket-Location header). To keep this code path tested for RFC 6455 protocol, too, we were setting the ws_location attribute of _StandaloneRequest object using one manually built from the host header and the resource inside the _wsh.py file.

Since Chromium no longer supports HyBi 00, we've cleaned up these Sec-WebSocket-Location related files and code, and added back some new layout test items that directly check the host header and the resource.

http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/websocket/tests/hybi/echo-host_wsh.py
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/websocket/tests/hybi/echo-path_wsh.py

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.