[Webkit-unassigned] [Bug 116049] Add a DisplayAndPowerController class to handle IOKit Display and Power notifications

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116049


Roger Fong <roger_fong at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #201661|0                           |1
        is obsolete|                            |
 Attachment #201661|review?                     |
               Flag|                            |
 Attachment #201778|                            |review?
               Flag|                            |




--- Comment #7 from Roger Fong <roger_fong at apple.com>  2013-05-14 18:43:01 PST ---
Created an attachment (id=201778)
 --> (https://bugs.webkit.org/attachment.cgi?id=201778&action=review)
patch

I've made some of the aforementioned changes.
In addition I've gotten rid of Power notifications and decided to leave that where it is.
It was pointed out other platforms might not get their power and display notifications from the same library like we do with IOKit so there's no reason to really have them in the same place anyways.
The resulting class in a singleton DisplayNotificationObserver class.

I also believe that keeping track of the display state via s_screenDimmed and having other classes (like FrameSelection) query said display state is the cleanest way to do things for something this lightweight and specific in usage. Plus now there's only two things in the IF PLATFORM(MAC) after getting rid of that power stuff.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.