[Webkit-unassigned] [Bug 115890] [EFL] Implement colorpicker for HTML5 input type color on Minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115890





--- Comment #11 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2013-05-13 23:02:16 PST ---
(From update of attachment 201680)
View in context: https://bugs.webkit.org/attachment.cgi?id=201680&action=review

It would be good if you submit a screenshot of color picker by this patch.

> Tools/MiniBrowser/efl/main.c:614
> +on_colorpalette_clicked(void *data, Evas_Object *obj, void *event_info)

Looks color_palette better.

> Tools/MiniBrowser/efl/main.c:625
> +on_colorpalette_longpressed(void *data, Evas_Object *obj, void *event_info)

ditto. longpressed -> long_pressed ?

> Tools/MiniBrowser/efl/main.c:636
> +on_colorpicker_ok_clicked(void *data, Evas_Object *obj, void *event_info)

ditto.

> Tools/MiniBrowser/efl/main.c:648
> +on_colorpicker_dismiss(Ewk_View_Smart_Data *sd)

ditto

> Tools/MiniBrowser/efl/main.c:657
> +on_colorpicker_request(Ewk_View_Smart_Data *sd, Ewk_Color_Picker* color_picker)

Wrong * place at Ewk_Color_Picker* color_picker.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.