[Webkit-unassigned] [Bug 115890] [EFL] Implement colorpicker for HTML5 input type color on Minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115890


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #201671|1                           |0
        is obsolete|                            |




--- Comment #9 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2013-05-13 20:50:24 PST ---
(From update of attachment 201671)
View in context: https://bugs.webkit.org/attachment.cgi?id=201671&action=review

r- because of efl ews fail and some comments.

> Tools/ChangeLog:8
> +        When user click HTML5 input type color, 

click -> clicks

> Tools/ChangeLog:11
> +        The evas_objet_color_set() set a color value returning to browser.

set -> sets ?

> Tools/MiniBrowser/efl/main.c:666
> +    cp_data->colorPicker = color_Picker;

colorPicker -> color_picker ?

> Tools/MiniBrowser/efl/main.c:693
> +    fr = elm_frame_add(window->color_selector);

I don't see why you add a frame to *fr* as well as 679 line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.