[Webkit-unassigned] [Bug 42693] WebKitTestRunner needs layoutTestController.setPrinting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42693


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #201651|review?                     |review+
               Flag|                            |




--- Comment #6 from Darin Adler <darin at apple.com>  2013-05-13 17:55:04 PST ---
(From update of attachment 201651)
View in context: https://bugs.webkit.org/attachment.cgi?id=201651&action=review

> Tools/ChangeLog:17
> +        (TestRunner):

Bogus line added by prepare-ChangeLog.

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:879
> +            WKRetainPtr<WKStringRef> text(AdoptWK, WKBundlePageCopyRenderTreeExternalRepresentationForPrinting(m_page));
> +            stringBuilder.append(toWTFString(text));

Should use adoptWK function, not the AdoptWK constructor, here. Also probably reads better without a local variable, like this:

    stringBuilder.append(toWTFString(adoptWK(WKBundlePageCopyRenderTreeExternalRepresentationForPrinting(m_page)).get()));

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:882
> +            WKRetainPtr<WKStringRef> text(AdoptWK, WKBundlePageCopyRenderTreeExternalRepresentation(m_page));
> +            stringBuilder.append(toWTFString(text));        

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.