[Webkit-unassigned] [Bug 115721] [GTK] Always use EGL to create the GL context when running on Wayland

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115721





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2013-05-11 12:45:19 PST ---
(From update of attachment 200890)
View in context: https://bugs.webkit.org/attachment.cgi?id=200890&action=review

> Source/WebCore/platform/graphics/cairo/GLContext.cpp:128
> +    GdkDisplay* display =
> +        gdk_display_manager_get_default_display(gdk_display_manager_get());
> +

It's okay for this to be one line. Lines in WebKit extend to 120 characters and beyond (beyond, beyond, beyond...).

> Source/WebCore/platform/graphics/cairo/GLContext.cpp:167
> +    GdkDisplay* display =
> +        gdk_display_manager_get_default_display(gdk_display_manager_get());
> +
> +    if (GDK_IS_WAYLAND_DISPLAY(display)) {
> +        if (OwnPtr<GLContext> eglContext = GLContextEGL::createContext(0, sharingContext))
> +            return eglContext.release();
> +        return nullptr;
> +    }
> +#endif
> +
>  #if USE(GLX)
>      if (OwnPtr<GLContext> glxContext = GLContextGLX::createContext(0, sharingContext))
>          return glxContext.release();

To avoid code duplication, could this method just call GLContext::createContextForWindow(0, sharingContext)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.