[Webkit-unassigned] [Bug 115564] Web Inspector: Implement WK2 version of WebInspectorFrontendClient::save

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115564


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin at webkit.org




--- Comment #32 from Benjamin Poulain <benjamin at webkit.org>  2013-05-10 19:25:53 PST ---
(In reply to comment #29)
> > > Source/WebKit2/UIProcess/WebInspectorProxy.h:169
> > > +    void platformSave(const String& filename, const String& content, bool forceSaveAs);
> > > +    void platformAppend(const String& filename, const String& content);
> > 
> > I find it intrinsically weird to pass any file content as String. I am not aware of any API that works like that.
> 
> The use case is that the Inspector serializes collected runtime data (ie., Timeline profiles) into a JSON string and it's written to disk by InspectorFrontendHost. The API is not used for saving any other type of data currently.
> 
> I guess it could be encoded earlier and passed around as a blob behind the scenes, at least on WK2. Is there a preferred way to do that? CoreIPC::DataReference? Or going further, should we push blob construction down into the inspector frontend?

A Vector of uchar8_t is commonly used to pass raw bytes.

It is probably okay for now as you say it is only use with JSON.
If you ever need to convert data to string to pass it through the API, please change the API instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.