[Webkit-unassigned] [Bug 115556] [CMake] Don't compile SVG/MATHML files if they are not enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115556


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rwlbuis at gmail.com




--- Comment #18 from Rob Buis <rwlbuis at gmail.com>  2013-05-10 11:45:17 PST ---
Hi Mark,

(In reply to comment #14)
> (In reply to comment #13)
> > (From update of attachment 200440 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=200440&action=review
> > 
> > Mark, can you fix the Reviewed by line?
> > 
> > >> Source/WebCore/ChangeLog:6
> > >> +        Unreviewed.
> > > 
> > > This patch is back to previous. At least, I think that it should be reviewed.
> > 
> > This patch seems fine but I agree, please keep the normal Reviewed by line in.
> 
> Thanks Rob.
> 
> What should it be?
> 
> Reviewed by Rob Buis ?
> 
> When I submit a patch, changelog comments are required, which require a "reviewed by" statement, but at that point no one has reviewed the patch.  Sort of a chicken and egg problem...
> 
> "Unreviewed" passes the style bot, as well as "Reviewed by <reviewer>".

I understand now. I agree with Gyuyoung Kim, using Tools/Scripts/prepare-ChangeLog <directory> prevents this problem. It should up showing like "Reviewed by (OOPS!)". It is better not to fill in the (who you think will be) reviewer name, that is a bit cheeky :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.