[Webkit-unassigned] [Bug 115917] svg/as-image/img-zoom-svg-stylesheet.html crashes with NetworkProcess enabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 10 11:01:28 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=115917


Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|webkit-unassigned at lists.web |beidson at apple.com
                   |kit.org                     |
 Attachment #201362|                            |review?
               Flag|                            |




--- Comment #1 from Brady Eidson <beidson at apple.com>  2013-05-10 10:59:54 PST ---
Created an attachment (id=201362)
 --> (https://bugs.webkit.org/attachment.cgi?id=201362&action=review)
Patch v1

This patch is straight forward and makes things much safer in WK2.

I don't feel great about it - It is arguably a layering violation in FrameLoaderClient.  But definitely less of one than "hasWebView" is, for example.

That said, I can't think of a fix for this problem that:
A - Isn't much more hackey (exposing an "isEmptyFrameLoaderClient() method, for example)
B - Doesn't require much more refactoring of Frame/FrameLoader/Page (pushing ID's down in to WebCore)
C - Doesn't require much more refactoring of SVG-as-images (making them use the normal WebFrame mechanism instead of directly creating their own WebCore::Frame

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list