[Webkit-unassigned] [Bug 115631] MemoryChache::prune() unnecessarily tries prune resources if m_maxDeadCapacity == 0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 10 04:13:29 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=115631





--- Comment #4 from Marcin Bychawski <m.bychawski at samsung.com>  2013-05-10 04:11:54 PST ---
(In reply to comment #3)
> (From update of attachment 200652 [details])
> This looks fine to me.  Is there any case we now fail, such as 'm_maxDeadCapacity == 0' and 'm_deadSize < 0' that might now get through and cause a problem?

I don't see any case we now can fail.
m_deadSize is unsigned, so it can't be < 0.
When m_maxDeadCapacity == 0, we need to prune resources only when m_deadSize > 0, so there condition 'm_deadSize <= m_maxDeadCapacity' is enough.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list