[Webkit-unassigned] [Bug 115865] Web Inspector: implement runOpenPanel callback for WebKit2-hosted inspector page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115865





--- Comment #3 from Brian Burg <burg at cs.washington.edu>  2013-05-09 18:59:29 PST ---
(In reply to comment #2)
> (From update of attachment 201295 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=201295&action=review
>
> > Source/WebKit2/UIProcess/WebInspectorProxy.h:99
> > +    NSWindow* inspectorWindow() const { return m_inspectorWindow.get(); }
> 
> This will only be non-nil when the Inspector is detached. I assume that is what you wanted, since having the open panel as a sheet on the Safari window when docked would be odd.

I added an assert and early exit in this unlikely case.

> > Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:37
> > +#import "WKRetainPtr.h"
> 
> I don't think you use this? You should if you can.

It's used to refcount the listener object.

> > Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:245
> > +                WKURLRef wkURL = WKURLCreateWithCFURL((CFURLRef)nsURL);
> 
> Use static_cast<CFURLRef>(nsURL) instead.

I can't :-( I think this is related to __CFURL being an opaque type. Normally, for such toll-free bridged types I wouldn't expect a cast to be required. So, I changed it to reinterpret_cast.

"Cannot cast from type 'NSURL *' to pointer type 'CFURLRef' (aka 'const __CFURL *')"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.