[Webkit-unassigned] [Bug 105156] [EFL] Process launcher uses system() for wrapping the WebProcess when using WEB_PROCESS_CMD_PREFIX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105156





--- Comment #11 from Sergio Correia <sergio.correia at openbossa.org>  2013-05-08 07:46:16 PST ---
(In reply to comment #9)
> (From update of attachment 200414 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=200414&action=review
> 
> > Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:38
> > +class ProcessExecArgs {
> 
> Still think it should not be class, we never need having an object instance.
> 

Okay, I removed the class in the new patch.

> > Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:53
> > +        for (i = 0, numArgs = prefixArgs.size(); i < numArgs; i++)
> 
> I'd put numArgs = prefixArgs.size() out of 'for()'
> 

Done.

> > Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:101
> > +    String processCmdPrefix;
> 
> Seems this var is not needed, m_launchOptions.processCmdPrefix can be passed directly.

m_launchOptions.processCmdPrefix only exists under #ifndef NDEBUG, so I think we need this variable, just like we need pluginPath, for instance. Anyway, please take a look at the updated version and let me know if you still think this variable is not needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.