[Webkit-unassigned] [Bug 105156] [EFL] Process launcher uses system() for wrapping the WebProcess when using WEB_PROCESS_CMD_PREFIX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105156





--- Comment #9 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2013-05-08 05:31:25 PST ---
(From update of attachment 200414)
View in context: https://bugs.webkit.org/attachment.cgi?id=200414&action=review

> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:38
> +class ProcessExecArgs {

Still think it should not be class, we never need having an object instance.

> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:53
> +        for (i = 0, numArgs = prefixArgs.size(); i < numArgs; i++)

I'd put numArgs = prefixArgs.size() out of 'for()'

> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:101
> +    String processCmdPrefix;

Seems this var is not needed, m_launchOptions.processCmdPrefix can be passed directly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.