[Webkit-unassigned] [Bug 115028] [EFL] Add command line option to MiniBrowser to set cookies policy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115028





--- Comment #3 from Andrzej Badowski <a.badowski at samsung.com>  2013-05-08 03:29:31 PST ---
(From update of attachment 199210)
View in context: https://bugs.webkit.org/attachment.cgi?id=199210&action=review

>> Tools/ChangeLog:7
>> +
> 
> Missing description.

I will add it in next patch.

>> Tools/MiniBrowser/efl/main.c:53
>> +static ushort cookies_policy = EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY;
> 
> Do you have any reason to set EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY instead of EWK_COOKIE_ACCEPT_POLICY_ALWAYS ?  Isn't EWK_COOKIE_ACCEPT_POLICY_ALWAYS default value ?

Some comments to code say that EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY is default value.

>> Tools/MiniBrowser/efl/main.c:1669
>> +    cookies_policy = cookies_policy % 3;
> 
> I think we should remain that user can set the policy.

There's an extra protection to set for the policy only an allowed value.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.