[Webkit-unassigned] [Bug 115564] Web Inspector: Implement WK2 version of WebInspectorFrontendClient::save

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 7 20:31:21 PDT 2013


--- Comment #17 from Timothy Hatcher <timothy at apple.com>  2013-05-07 20:29:44 PST ---
(From update of attachment 201018)
View in context: https://bugs.webkit.org/attachment.cgi?id=201018&action=review

>> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:508
>> +    String suggestedURLCopy = suggestedURL;
> I don't think it makes a difference to "copy" here, String isn't mutable. Or was it needed for the block?
> Should we ASSERT and return early if !suggestedURL.isEmpty()? It would be weird to map empty string to a platform URL.

Ooops, I meant "ASSERT and return early if suggestedURL.isEmpty()".

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list