[Webkit-unassigned] [Bug 115763] Make caret not blink when entering dimmed display state before going to display sleep

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115763





--- Comment #4 from Tim Horton <timothy_horton at apple.com>  2013-05-07 17:11:44 PST ---
(From update of attachment 200999)
View in context: https://bugs.webkit.org/attachment.cgi?id=200999&action=review

> Source/WebCore/ChangeLog:9
> +        Update RenderTheme to keep track of the receive display sleep notifications and keep track of the display's state.

keep track of the receive?

> Source/WebCore/editing/FrameSelection.cpp:1849
> +    if (m_frame->view()->renderView()->theme()->isScreenDimmed() || (isCaretBlinkingSuspended() && caretPaint))

Can any of these ever be null?

> Source/WebCore/rendering/RenderTheme.h:350
> +    static bool m_screenDimmed;

I think that statics use s instead of m or something but you should look it up. Also maybe this should just be in the RenderThemeMac file and not in this class at all? But I dunno.

> Source/WebCore/rendering/RenderThemeMac.h:262
> +    io_service_t m_displayWrangler;

This is pretty bizarre to be in RenderTheme*.

> Source/WebCore/rendering/RenderThemeMac.mm:2316
> +        case kIOMessageDeviceWillPowerOff:
> +            m_screenDimmed = true;
> +            break;
> +            
> +        case kIOMessageDeviceHasPoweredOn:
> +            m_screenDimmed = false;
> +            break;

This is not indented correctly. Does this really need to be a switch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.