[Webkit-unassigned] [Bug 42324] WebKitTestRunner needs testRunner.dumpDOMAsWebArchive

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 7 13:51:56 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=42324


Tim Horton <timothy_horton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #200967|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #12 from Tim Horton <timothy_horton at apple.com>  2013-05-07 13:50:20 PST ---
(From update of attachment 200967)
View in context: https://bugs.webkit.org/attachment.cgi?id=200967&action=review

> Tools/ChangeLog:10
> +        Added dumpDOMAsWebArchive javascript function to be called by test cases.

JavaScript

> Tools/ChangeLog:21
> +        Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMASWebArchive.

I think it's "As" not "AS". Too many caps :)

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:53
> +#import <CoreFoundation/CoreFoundation.h>

Isn't this already included by WebArchiveDumpSupport.h?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list