[Webkit-unassigned] [Bug 42324] WebKitTestRunner needs testRunner.dumpDOMAsWebArchive

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42324





--- Comment #10 from Tim Horton <timothy_horton at apple.com>  2013-05-07 11:28:14 PST ---
(From update of attachment 200927)
View in context: https://bugs.webkit.org/attachment.cgi?id=200927&action=review

>> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:850
>> +    CFDataRef cfData = CFDataCreate(0, bytes, length);
> 
> This could be all-in-one-line too.
> 
> Also, you're leaking the CFData object.

You should use something like RetainPtr<CFDataRef> cfData = adoptCF(CFDataCreate(0, ...));

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.