[Webkit-unassigned] [Bug 115647] Replace deprecated call to atk_document_get_locale() in DumpRenderTree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115647


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario at webkit.org




--- Comment #10 from Mario Sanchez Prada <mario at webkit.org>  2013-05-07 07:39:54 PST ---
(In reply to comment #9)
> After discussing this with Alejandro (ATK maintainer), my proposal is to:
> 
> 1) move the current implementation of get_locale() from AtkDocument interface, to AtkObject get_object_locale() virtual method. With this, it is safe to replace atk_document_get_locale() by atk_object_get_object_locale() for document objects.
> 
> 2) take the logic used in AccessibilityUIElement::language() to get the locale for AtkText objects, and move it to get_object_locale() virtual method of AtkObject. With this, we can call atk_object_get_object_locale() on AtkText objects as well, we clean up the language() method, and improve encapsulation.
> 
> Alejandro, Martin, do you agree with this plan?

Even I'm neither Alejandro nor Martin I would like to say I agree with this plan too :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.