[Webkit-unassigned] [Bug 112162] [BlackBerry] Implement platform strategies

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 7 00:47:14 PDT 2013


--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-05-07 00:45:37 PST ---
(In reply to comment #7)
> (From update of attachment 200661 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=200661&action=review
> > Source/WebCore/platform/network/blackberry/CookieJarBlackBerry.cpp:45
> > +    return !cookieManager().cookieJar().isEmpty();
> otcheung says: for us, cookieManager().cookieJar() holds the file name of the cookie database file. It's always init to some string object so it'll always return true in this case. since we don't have access to the websettings object through document anymore, we may want to have ftns that toggles the availability of cookies in cookiemanager, and update those values with the toggles in WebPageClientImpl. However, that seems quite unclean because we'll be storing the cookieenabled bool in multiple places.

This cookiesEnabled() means whether cookies are available from a platform point of view. See the Navigator::cookieEnabled() implementation for example, it first checks whether the cookies are enabled for the page settings and then it calls cookiesEnabled(). See also Document::cookie() and Document::setCookie(), platform cookies methods are only called if the cookies are enabled in the page settings (and if the security origin allows to access cookies). In the soup implementation, for example, we check if the soup cookie jar feature is available in the soup session.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list