[Webkit-unassigned] [Bug 114966] [Qt] QWebKitPlatformPlugin should export available Plugin interfaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114966





--- Comment #19 from Simon Hausmann <hausmann at webkit.org>  2013-05-07 00:34:09 PST ---
(In reply to comment #18)
> (In reply to comment #17)
> > Then you still get crashes when QtWebKit tries to load a platform plugin that was compiled against the wrong version of the interface.
> > 
> > The crash is what the interface cast and versioning is supposed to protect us against.
> 
> m_plugin = qobject_cast<QWebKitPlatformPlugin*>(obj);
> 
> qobject_cast will do it right?(specialized version for Q_DECLARE_INTERFACE)

Yes, exactly.

> > 
> > If we're willing to give that up, then we could export symbols and actual base classes.
> 
> You guys have to decide :), I'm always +1 for exporting symbols.
> 
> I also added parent parameter to createExtension like below,
> 
> virtual QObject* createExtension(Extension, QObject* parent = 0) const = 0;. 
> 
> What do you think?

Can you explain why you would like to add the parent? (the ChangeLog does not mention why)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.